Switch to Staffbase Artifactory as new default docker registry#59
Merged
Switch to Staffbase Artifactory as new default docker registry#59
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
recheck |
monotek
approved these changes
Jan 24, 2023
monotek
requested changes
Jan 24, 2023
0x46616c6b
requested changes
Jan 24, 2023
ricoberger
approved these changes
Jan 25, 2023
ricoberger
approved these changes
Jan 25, 2023
staffbase-robert
approved these changes
Jan 26, 2023
Contributor
Author
|
In a few talks we decided to keep the defaults Staffbase specific. Just removing the registry URL default didn't feel right, as we also set other Staffbase specific defaults like the GitHub User, the gitops repository name, …. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This switches the default registry from registry.staffbase.com to staffbase.jfrog.io which is our new prefered way of releasing images.
The idea would be to release a new version of this action and have repositories switch gradually.
When updating there is also the need to switch the following:
/privatewith/sb-imagesDOCKER_USERNAMEwithARTIFACTORY_USERNAMEDOCKER_PASSWORDwithARTIFACTORY_PASSWORDregistry.staffbase.comwithstaffbase.jfrog.ioThe new secrets are available as a company-wide Github secret or environment variable.
Clusters are already prepared for the change and should be able to pull images from the new registry.
Checklist